I know he's no good for me, but I'm still holding on?

You're needy and co-dependent and will trade him in when someone better comes along. Accept it, or try to work on yourself and leave him before it gets to that point.